powertoys: Change checkver to github, fix autoupdate#17744
powertoys: Change checkver to github, fix autoupdate#17744ENDlezZenith wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
📝 WalkthroughWalkthroughThe manifest file for the PowerToys application was updated to simplify its version checking configuration. The Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/powertoys.json (1)
79-79: ⚡ Quick win
"checkver": "github"is correct; also consider bumping the version to0.99.1in this PRThe current latest release is tagged
v0.99.1, so"checkver": "github"will correctly strip the leadingvand resolve to0.99.1. TheautoupdateURL templates already use$versionwith no hardcoded strings, so the automated pipeline will produce the right download URLs once the version is updated.The manifest still ships at
0.99.0after this change — that's fine if the expectation is for the autoupdate bot to bump it post-merge, but you can also bundle the version bump here by running.\bin\checkver.ps1 -App powertoys -flocally and including the resulting diff.📋 Manual bump to 0.99.1 (optional — run checkver.ps1 instead of hand-editing)
- "version": "0.99.0", + "version": "0.99.1", ... - "url": "https://github.com/microsoft/PowerToys/releases/download/v0.99.0/PowerToysUserSetup-0.99.0-x64.exe", - "hash": "1e3586a2ecd454b86fe61c44b003e0027fcc24dcb5135958b73d04a58285618c" + "url": "https://github.com/microsoft/PowerToys/releases/download/v0.99.1/PowerToysUserSetup-0.99.1-x64.exe", + "hash": "cad34aa632251cfb9bda1d6fe70e0bd5c150ac6fec7afb0ba179df90413430cd" ... - "url": "https://github.com/microsoft/PowerToys/releases/download/v0.99.0/PowerToysUserSetup-0.99.0-arm64.exe", - "hash": "2bca2a1edb0077faf752dde95c8d02a0a7a70f8e5128f43ea58432bbbe4e3c62" + "url": "https://github.com/microsoft/PowerToys/releases/download/v0.99.1/PowerToysUserSetup-0.99.1-arm64.exe", + "hash": "7bd4c3e66d64339c40dd42ec58de8f25e2b81ecd90c45f0ad95247024f508705"Hash values sourced from the official v0.99.1 release page.
🧪 Testing instructions (per contribution guidelines):
# Optional: enable debug + GitHub token for API access scoop config debug true scoop config gh_token <your-github-token> # Verify checkver detects 0.99.1 and autoupdate produces correct URLs .\bin\checkver.ps1 -App powertoys -f # Lint/format the manifest .\bin\formatjson.ps1 -App powertoys # Test installation per architecture scoop install bucket/powertoys.json -a 64bit scoop install bucket/powertoys.json -a arm64For more details, see the Contribution Guide and App Manifests wiki.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/powertoys.json` at line 79, The manifest already uses "checkver": "github" correctly but the package version in the manifest should be bumped to v0.99.1 and the new release hashes included; run .\bin\checkver.ps1 -App powertoys -f locally to auto-detect 0.99.1 and update the "version" and SHA fields, then run .\bin\formatjson.ps1 -App powertoys to format the manifest and validate that autoupdate templates using $version produce the correct URLs; finally verify by testing installation for 64bit and arm64 as described in the review comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/powertoys.json`:
- Line 79: The manifest already uses "checkver": "github" correctly but the
package version in the manifest should be bumped to v0.99.1 and the new release
hashes included; run .\bin\checkver.ps1 -App powertoys -f locally to auto-detect
0.99.1 and update the "version" and SHA fields, then run .\bin\formatjson.ps1
-App powertoys to format the manifest and validate that autoupdate templates
using $version produce the correct URLs; finally verify by testing installation
for 64bit and arm64 as described in the review comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8bbeaecd-4deb-4b67-be4d-d5571f3691ec
📒 Files selected for processing (1)
bucket/powertoys.json
|
Closing, waiting for comprehensive PR similar to ScoopInstaller/Versions#2837. |
The powertoys manifest is not autoupdaing to 0.99.1 which is released 3 days ago, in which the scoop manifest shows that it is still on 0.99.0. This PR changes the checkver to the conventional GitHub method which is
"checkver": "github",. It is confirmed to fix the bug and would be able to autoupdate to 0.99.1. Actually, don't know why the powertoys manifest is using a checkver in a manual manner in the case that it is a GitHub repo:If this was done deliberately, please ignore this PR.
Closes #17743
<manifest-name[@version]|chore>: <general summary of the pull request>